[PATCH] kexec: add further check to crashkernel

DuanZhenzhong zhenzhong.duan at oracle.com
Mon Mar 12 23:10:31 EDT 2012


From: Zhenzhong Duan <zhenzhong.duan at oracle.com>

When add crashkernel=2M-256M, kernel don't give any warning.
This is misleading sometimes.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan at oracle.com>
---
 kernel/kexec.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/kernel/kexec.c b/kernel/kexec.c
index 7b08867..0a6d147 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1359,6 +1359,10 @@ static int __init parse_crashkernel_simple(char 		*cmdline,
 
 	if (*cur == '@')
 		*crash_base = memparse(cur+1, &cur);
+	else if (*cur != ' ' && *cur != '\0') {
+		pr_warning("crashkernel: unrecognized char\n");
+		return -EINVAL;
+	}
 
 	return 0;
 }
-- 1.7.3




More information about the kexec mailing list