[PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations

Will Deacon will.deacon at arm.com
Mon Feb 27 14:30:54 EST 2012


On Mon, Feb 27, 2012 at 12:37:30AM +0000, Simon Horman wrote:
> On Sun, Feb 26, 2012 at 10:58:42PM +0000, Will Deacon wrote:
> > On Sat, Feb 25, 2012 at 02:37:49AM +0000, Simon Horman wrote:
> > 
> > > might this cover cases where swapper_pg_dir is interesting?
> > 
> > The only case where it's interesting is when you have CONFIG_MMU enabled -
> > otherwise it's always NULL. If it's #defined as NULL, the current code will
> > fail at build time so simply omitting it from the dump seems like the best
> > bet to me (the alternative being to add a NULL entry explicitly, but I don't
> > see what the gains us).
> 
> Hi Will,
> 
> thanks for the clarification. FWIW I am happy with your patch.
> 
> Reviewed-by: Simon Horman <horms at verge.net.au>

Cheers, Simon. What's the usual path for generic kexec code getting into
mainline? Do I need to get this queued somewhere?

Will



More information about the kexec mailing list