[PATCH][makedumpfile] sadump: check if given cpu is online in per-cpu related helper functions
d.hatayama at jp.fujitsu.com
Thu Apr 5 04:10:41 EDT 2012
From: Atsushi Kumagai <kumagai-atsushi at mxc.nes.nec.co.jp>
Subject: Re: [PATCH][makedumpfile] sadump: check if given cpu is online in per-cpu related helper functions
Date: Thu, 5 Apr 2012 16:23:20 +0900
> Hello Hatayama-san,
> On Mon, 20 Feb 2012 18:17:40 +0900 ( )
> HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> wrote:
>> > On Mon, 20 Feb 2012 11:19:15 +0900 ( )
>> > HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> wrote:
>> >> Per-cpu helper functions sanity check given cpu ids if they are
>> >> not-minus and less than the maximal but it should have checked if they
>> >> are online. By this mistake, one cannot see generated vmcore correctly
>> >> if sadump collects vmcore when some cpus are offline e.g. using cpu
>> >> hotplug or panic and so all the cpus except for a unique CPU halting.
>> >> Signed-off-by: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com>
>> >> ---
>> >> sadump_info.c | 18 ++++++++++++++----
>> >> 1 files changed, 14 insertions(+), 4 deletions(-)
>> > Thank you for your patch.
>> > I will review it and it will be merged into v1.4.4
>> > because I'm preparing the release of v1.4.3 now.
>> > Thanks
>> > Atsushi Kumagai
>> I see. Thanks.
> Sorry for late reply.
> I reviewed your patch and it looks good.
> I will merge it into v1.4.4 as planned.
I see. Thanks for your review.
More information about the kexec