[Patch 1/4][kernel][slimdump] Add new elf-note of type NT_NOCOREDUMP to capture slimdump

Nick Bowler nbowler at elliptictech.com
Tue Oct 4 11:04:17 EDT 2011


On 2011-10-03 13:02 +0530, K.Prasad wrote:
> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> index 08363b0..483b2fc 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -238,6 +238,34 @@ static atomic_t mce_paniced;
>  static int fake_panic;
>  static atomic_t mce_fake_paniced;
>  
> +void arch_add_nocoredump_note(u32 *buf)
> +{
> +	struct elf_note note;
> +	const char note_name[] = "PANIC_MCE";

        static const ...

> +	const char desc_msg[] = "Crash induced due to a fatal machine "
> +				"check error";

        likewise.

Please don't break string literals onto multiple lines like this, since
it prevents users from finding the string using "grep".

Cheers,
-- 
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)



More information about the kexec mailing list