[PATCH] kdump: kill redundant code

Dave Young dyoung at redhat.com
Wed Nov 9 02:04:52 EST 2011


in while loop below, hole_end > crashk_res.end is impossible:
while (hole_end <= crashk_res.end) {
	[snip]
}
Killing the check code here

Signed-off-by: Dave Young <dyoung at redhat.com>
---
 kernel/kexec.c |    2 --
 1 file changed, 2 deletions(-)

--- linux-2.6.orig/kernel/kexec.c	2011-11-01 13:06:20.000000000 +0800
+++ linux-2.6/kernel/kexec.c	2011-11-09 14:57:17.487022644 +0800
@@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c
 
 		if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
 			break;
-		if (hole_end > crashk_res.end)
-			break;
 		/* See if I overlap any of the segments */
 		for (i = 0; i < image->nr_segments; i++) {
 			unsigned long mstart, mend;



More information about the kexec mailing list