[RFC][PATCH] Kexec support for PPC440x
Sebastian Andrzej Siewior
bigeasy at linutronix.de
Tue May 31 11:15:35 EDT 2011
Suzuki Poulose wrote:
> Index: powerpc/arch/powerpc/kernel/44x_kexec_mapping.S
> ===================================================================
> --- /dev/null
> +++ powerpc/arch/powerpc/kernel/44x_kexec_mapping.S
....
> + *
> + */
> + bl nxtins /* Find our address */
> +nxtins: mflr r5 /* Make it accessible */
Please don't mix labels and instructions.
> + tlbsx r23,0,r5 /* Find entry we are in */
using tabs instead of spaces would make it look nice. Please also separate
the arguments of the instruction i.e.
tlbsx r23, 0, r5
> Index: powerpc/arch/powerpc/kernel/misc_32.S
> ===================================================================
> --- powerpc.orig/arch/powerpc/kernel/misc_32.S
> +++ powerpc/arch/powerpc/kernel/misc_32.S
> @@ -736,6 +736,28 @@ relocate_new_kernel:
> mr r5, r31
>
> li r0, 0
> +#elif defined(CONFIG_44x) && !defined(CONFIG_47x)
> +
> + mr r29, r3
> + mr r30, r4
> + mr r31, r5
> +
> +#include "44x_kexec_mapping.S"
The way you setup the 1:1 mapping should be close to what you are doing on
kernel entry. Isn't it possible to include the file here and in the entry
code?
Sebastian
More information about the kexec
mailing list