[PATCH] makedumpfile: s390x: Fix KVBASE to correct value for s390x arcitecture.

Ken'ichi Ohmichi oomichi at mxs.nes.nec.co.jp
Thu Mar 17 02:39:12 EDT 2011


Hi Mahesh,

On Tue, 15 Mar 2011 22:39:23 +0530
Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> wrote:
>
> From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> 
> While excluding free pages from s390x dumps taken on LPAR, makedumpfile
> fails to convert page address to pfn. The reason is, the memory for
> mem_section structure is allocated below '_stext' and since KVBASE is
> set to SYMBOL(_stext), the function is_kvaddr() fails and return NULL
> address.

Why do we need this patch ?
to support the latest kernel version of s390 ?
or to support LPAR of s390 ?

I'd like to know whether we need a similar change for the other architecture.
I will appreciate if getting a hint.


Thanks
Ken'ichi Ohmichi

> Set KVBASE to KENRELBASE(0) for s390x architecture to fix this issue.
> 
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> ---
> 
>  makedumpfile.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/makedumpfile.h b/makedumpfile.h
> index 11e1a93..4ec77b7 100644
> --- a/makedumpfile.h
> +++ b/makedumpfile.h
> @@ -615,7 +615,7 @@ do { \
>  #ifdef __s390x__
>  #define __PAGE_OFFSET		(info->page_size - 1)
>  #define KERNELBASE		(0)
> -#define KVBASE			(SYMBOL(_stext))
> +#define KVBASE			KERNELBASE
>  #define _SECTION_SIZE_BITS	(28)
>  #define _MAX_PHYSMEM_BITS	(42)
>  
> 



More information about the kexec mailing list