[PATCH] makedumpfile: Copy correct nr_cpus info to dumpfile during re-filtering

Ken'ichi Ohmichi oomichi at mxs.nes.nec.co.jp
Fri Mar 11 00:29:22 EST 2011


Hi Mahesh,

Nice catching!
Your patch has been merged to mainline:
http://makedumpfile.git.sourceforge.net/git/gitweb.cgi?p=makedumpfile/makedumpfile;a=summary

Thank you very much.


Thanks
Ken'ichi Ohmichi

On Wed, 09 Mar 2011 17:45:48 +0530
Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> wrote:
>
> From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> 
> During re-filtering nr_cpus is to 0 in the o/p dumpfile and hence crash
> utility fails to open the re-filtered dumpfile.
> 
> This patch fixes this issue by copying nr_cpus info from kdump-compressed
> dumpfile to info->nr_cpus which then get's correctly copied to o/p
> dumpfile.
> 
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> ---
> 
>  makedumpfile.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/makedumpfile.c b/makedumpfile.c
> index a0fad6a..7d0c663 100644
> --- a/makedumpfile.c
> +++ b/makedumpfile.c
> @@ -924,6 +924,7 @@ get_kdump_compressed_header_info(char *filename)
>  		goto error;
>  	}
>  	memcpy(info->kh_memory, &kh, sizeof(kh));
> +	info->nr_cpus = dh.nr_cpus;
>  
>  	if (dh.header_version >= 3) {
>  		/* A dumpfile contains vmcoreinfo data. */
> 




More information about the kexec mailing list