[Patch] kexec_load: check CAP_SYS_MODULE

[Eric W. Biederman]

Eric Paris <eparis at redhat.com> writes:

>> If I was building a configuration where I didn't want anyone to be able
>> to direct the kernel into a different state by locking down the
>> bootloaders I expect I would compile out the syscall as well.
>
> As sad as it may sound the vast majority of people don't build their own
> kernels.  And even those people who have the intelligence to do it are
> often constrained by some non-technical policy to run 'approved'
> kernels. 

Yes I am aware of the crazy game that is called approved kernels.  Where
there are too many regressions for people to trust new kernel releases
but people want to change the kernel and the setup from what was tested
and still have the stamp of approval anyway.  Financially it seems to
make people money, but as best I can tell that game is ultimately what
killed unix.

In this instance you seem to be redefining CAP_SYS_MODULE and
CAP_SYS_REBOOT so you can play that game. 

> Maybe I didn't make it clear how this is going to be used.  I plan to
> drop CAP_SYS_MODULE to stop root from loading their own modules and
> running their own code in the kernel.  I can control reboot() since I
> control the platform and the bootloader.  I cannot control kexec().  I'm
> also required to use a generic distro kernel (bet you can't guess which
> one)

If you are truly locked down I recommend dropping CAP_SYS_REBOOT and
setting up a watchdog that keeps the system from rebooting (standard
practice in embedded kinds of setups like you describe).  That should
meet everyone requirements without needing to game the system.

> The only solution I see to solve the problem is to gate kexec on
> CAP_SYS_MODULE.  Which makes sense since kexec() is in many respects
> close to module_init() than it is to reboot().

kexec_load is nothing like module_init().  All it does it puts data in
memory for use by a subsequent reboot.  /sbin/kexec is a bootloader that
runs inside of linux.  All you are noticing is that if you don't control
/sbin/kexec you aren't controlling the bootloader.

Eric