[PATCH] kexec-tools: remove unused code from arch_process_options (arm, cris, ia64, mips, ppc)

Simon Horman horms at verge.net.au
Thu May 13 10:29:15 EDT 2010


On Thu, May 13, 2010 at 05:50:56PM +1000, Matt Evans wrote:
> Matt Evans wrote:
> > These architectures don't have any architecture-specific options
> > (note: distinct from loader options, which are more specific), yet
> > their arch_process_options() functions contain getopts_long() calls
> > followed by no argument processing.  The code doesn't do anything,
> > so this patch removes it.
> > 
> > Signed-off-by: Matt Evans <matt at ozlabs.org>
> > ---
> >  kexec/arch/arm/kexec-arm.c   |   17 -----------------
> >  kexec/arch/cris/kexec-cris.c |   17 -----------------
> >  kexec/arch/ia64/kexec-ia64.c |   21 +++------------------
> >  kexec/arch/mips/kexec-mips.c |   17 -----------------
> >  kexec/arch/ppc/kexec-ppc.c   |   17 -----------------
> >  5 files changed, 3 insertions(+), 86 deletions(-)
> 
> I forgot to add that unfortunately I have only been able to compile this
> patch on ppc.  Since the code carefully removed doesn't have any effect I
> am hopeful for the rest...  :-)

Thanks, applied.

I successfully compiled the code for the other architectures
with the exception of cris (as I don't have access to the box
with that cross compiler at the moment).



More information about the kexec mailing list