[PATCH 31/40] trace syscalls: Convert various generic compat syscalls

Christoph Hellwig hch at infradead.org
Wed Jun 23 08:41:07 EDT 2010

On Wed, Jun 23, 2010 at 02:35:38PM +0200, Andi Kleen wrote:
> >I haven't heard any complains about existing syscalls wrappers.
> At least for me they always interrupt my grepping.
> >
> >What kind of annotations could solve that?
> If you put the annotation in a separate macro and leave the original
> prototype alone. Then C parsers could still parse it.

I personally hate the way SYSCALL_DEFINE works with passion, mostly
for the grep reason, but also because it looks horribly ugly.

But there is no reason not to be consistent here.  We already use
the wrappers for all native system calls, so leaving the compat
calls out doesn't make any sense.  And I'd cheer for anyone who
comes up with a better scheme for the native and compat wrappers.

More information about the kexec mailing list