[PATCH] Update MCP55 quirk to not affect non HyperTransport variants

Andrew Morton akpm at linux-foundation.org
Thu Dec 9 18:40:41 EST 2010


On Wed,  8 Dec 2010 09:47:48 -0500
Neil Horman <nhorman at tuxdriver.com> wrote:

> I wrote this quirk awhile ago to properly setup MCP55 chips on hypertransport
> busses so that interrupts reached whatever cpu happend to boot the kdump kernel.
> while that works well, it was recently shown to me that a a non-hypertransport
> variant of the MCP55 exists, and on those system the register that this quirk
> manipulates causes hangs if you write to it.  Since the quirk was only meant to
> handle errors found on MCP55 chips that have a HT interface, this patch adds a
> filter to make sure the chip is an HT capable before making the needed register
> adjustment.  This lets the broken MCP55s work with kdump while not breaking the
> non-HT variants.
> 
> Resolves https://bugzilla.kernel.org/show_bug.cgi?id=23952
> 
> Tested successfully by the reporter and myself.
> 
> Reported-by: Mathieu B__rard <mathieu at mberard.eu>
> CC: linux-pci at vger.kernel.org
> CC: kexec at lists.infradead.org
> CC: Vivek Goyal <vgoyal at redhat.com>
> CC: Jesse Barnes <jbarnes at virtuousgeek.org>
> Signed-off-by: Neil Horman <nhorman at tuxdriver.com>

That needed a Cc:<stable at kernel.org> as well.  Please don't forget to
remember -stable.



More information about the kexec mailing list