[PATCH] kexec.c: workaround getline and fscanf to make it *libc agnostic. Tested against klibc and dietlibc.

Bernhard Walle bernhard at bwalle.de
Sun Nov 22 04:24:30 EST 2009


Simon Horman schrieb:
>
>> +	char *line = malloc(sizeof_line); /* according to strdup() later */
>
> 	Could line be char line[1024] ?

Better would be a constant. However, 1024 is too less since the maximum
command line size can be 2048 currently on x86
(arch/x86/include/asm/setup.h, #define COMMAND_LINE_SIZE 2048).



Regards,
Bernhard



More information about the kexec mailing list