[PATCH] [PPC64] printf() consolidation

Bernhard Walle bwalle at suse.de
Fri Jan 16 13:11:45 EST 2009


Remove the fprintf(stderr,...) in get_memory_ranges() that adds unnecessary
output in the normal kexec case that the user don't want to see.

Use dbgprintf() in get_base_ranges() instead of

    #ifdef DEBUG
        fprintf(stderr,...)
    #endif

to to make the code more readable.


Signed-off-by: Bernhard Walle <bwalle at suse.de>diff --git a/kexec/arch/ppc64/kexec-ppc64.c b/kexec/arch/ppc64/kexec-ppc64.c
index ad8a31c..8d4e42b 100644
Signed-off-by: Bernhard Walle <bwalle at suse.de>
---
 kexec/arch/ppc64/kexec-ppc64.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/kexec/arch/ppc64/kexec-ppc64.c b/kexec/arch/ppc64/kexec-ppc64.c
index ad8a31c..8d4e42b 100644
--- a/kexec/arch/ppc64/kexec-ppc64.c
+++ b/kexec/arch/ppc64/kexec-ppc64.c
@@ -263,9 +263,8 @@ static int get_base_ranges(void)
 	closedir(dir);
 	sort_base_ranges();
 	memory_max = base_memory_range[nr_memory_ranges - 1].end;
-#ifdef DEBUG
-	fprintf(stderr, "get base memory ranges:%d\n", nr_memory_ranges);
-#endif
+	dbgprintf("get base memory ranges:%d\n", nr_memory_ranges);
+
 	return 0;
 }
 
@@ -726,7 +725,7 @@ int get_memory_ranges(struct memory_range **range, int *ranges,
 		sizeof(struct memory_range) * nr_memory_ranges);
 
 	*ranges = nr_memory_ranges;
-	fprintf(stderr, "get memory ranges:%d\n", nr_memory_ranges);
+	dbgprintf("get memory ranges:%d\n", nr_memory_ranges);
 	return 0;
 }
 
-- 
1.6.0.2




More information about the kexec mailing list