makedumpfile question / request

[Ken'ichi Ohmichi]

Hi Dave,

Dave Anderson wrote:
> Is there a reason that makedumpfile does not fill in the utsname structure
> in the compressed dumpfile's header?  

Thank you for good point.

makedumpfile does not fill it because makedumpfile might not be able to
get kernel debug information (containing symbol system_utsname/init_uts_ns).
makedumpfile does not need kernel debug information if dump_level is 0 or 1,
and it does not read a new_utsname structure. (check_release() is not called.)


> The data structure does get read into a local new_utsname structure in the
> check_release() function, but it doesn't get saved and copied into the
> disk_dump_header in write_kdump_header().
>
> It would be helpful if that were in place as a quick ID for what the
> compressed dumpfile contains.

I feel that is worth.
How about saving new_utsname data into disk_dump_header only if dump_level
is 2 or bigger ?


Thanks
Ken'ichi Ohmichi