[PATCH 15/16] kvm: x86: set kdump virt_disable function on initialization

Avi Kivity avi at redhat.com
Thu Nov 6 04:44:38 EST 2008


Eric W. Biederman wrote:
>>  
>> +	r = set_virt_disable_func(crash_hardware_disable);
>>     
>
> Can we make this say:
> set_virt_disable_func(kvm_x86_ops->crash_hardware_disable);
>
> So we can avoid going through 2 levels of function pointers?
> I find that a little scary in code that might be running
> at the edge of stack overflow.
>   

Actually, with scheduling disabled we can overflow the stack as much as 
we like.  It will reduce the quality of the dump, but everything ought 
to work.

-- 
error compiling committee.c: too many arguments to function




More information about the kexec mailing list