[Crash-utility] Re: [Xen-devel] [PATCH] Add xen_phys_start value in the crash info note

[Dave Anderson]

Keir Fraser wrote:
> On 30/5/08 06:13, "Itsuro ODA" <oda at valinux.co.jp> wrote:
>
>   
>> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
>> able to get the relocation address of the xen hypervisor from a vmcore.
>> It is necessary for the utilities to find the data of the hypervisor
>> structures.
>>
>> Note that this patch does not raise any comptibility issue for the
>> utilities (which I know) nor the other components of xen.
>>     
>
> Since it both changes the size of the crash_info elf note, and adds the new
> field in the middle of the crash_info structure, how can it not affect
> compatibility?
>
>  -- Keir
>   

Itsuro did it that way on purpose.  It maintains backwards compatibility by
keeping the dom0_pfn_to_mfn_frame_list_list field as the last field in the
PT_NOTE.  crash doesn't know what a crash_xen_info_t structure is, but only
its old and new size.

Dave