[PATCH] Use 'long long' for printf() format string and ELF64 numbers.

Bernhard Walle bwalle at suse.de
Wed May 28 03:22:25 EDT 2008


* Jamey Sharp [2008-05-27 17:48]:
>
> On Sun, May 25, 2008 at 1:11 PM, Bernhard Walle <bwalle at suse.de> wrote:
> >  kexec/crashdump-elf.c:160: warning: format '%lx' expects type \
> >        'long unsigned int', but argument 4 has type 'Elf64_Off'
> 
> This is what inttypes.h is for, right?
> 
> > dbgprintf("%s: p_type = %u, p_offset = 0x%llx p_paddr = 0x%llx " ...
> 
> Perhaps (... "p_offset = 0x" PRIx64 " p_paddr = 0x" PRIx64 ...)?

Yes, I know this, but it's really ugly to read IMO. If it's not really
necessary I think it's better to avoid it.



	Bernhard



More information about the kexec mailing list