[PATCH] Add --reuse-cmdline

Michael Neuling mikey at neuling.org
Mon May 12 15:43:57 EDT 2008



In message <20080512153849.74753e71 at kopernikus.site> you wrote:
> --Sig_/XVYJV.ZkU.f5R3y3b_UR6.k
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi,
> 
> at first thanks for looking at the patch.
> 
> * Michael Neuling <mikey at neuling.org> [2008-05-09 12:13]:
> >=20
> > In message <20080508204943.GA24160 at suse.de> you wrote:
> > > This patch adds an option "--reuse-cmdline" for people that are lazy in=
>  typin
> > g
> > > --append=3D"$(cat /proc/cmdline)". The advantage of "--reuse-cmdline" i=
> s also t
> > hat
> > > it strips off BOOT_IMAGE (since it may not be correct any more) from li=
> lo and
> > > other boot loaders, and, more important, the crashkernel option in case=
>  a
> > > panic kernel is loaded.
> > >=20
> > > If you like the option I can also add it for really all architectures. =
> Tested
> >  only
> > > with x86-bzImage both the kexec and kdump case.
> >=20
> > For ppc64, the default is to reuse the command line.  We should probably
> > merge functionality.
> 
> Where is that functionality implemented? I couldn't find it. Does the
> kernel that automatically on PPC64? I know too litte about that
> architecture.

Sorry, I think I was mistaken.  ppc64 only takes the "root=<blah>" from
the first kernel, provided it's not specified on the kexec command line
for the next kernel.

Anyway, the code is in kexec/arch/ppc64/fs2dt.c (search for "root=")

> > Either way, this should probably be a generic option, not x86 specific.
> 
> Well, I thought first of it. But since the '--append' parameter is not
> generic, this makes no sense.
> 
> Maybe it would make sense to change the command line handling in
> general to be global and not image specific, but first I need to
> understand how that works on PPC64 ... (and probably others).

Yeah, the cmdline should be generically and consistently handled rather
than what we have now.

Mikey



More information about the kexec mailing list