[PATCH] reduce alignment constraint on ia64 elf core header

Neil Horman nhorman at tuxdriver.com
Mon Mar 3 09:30:26 EST 2008


Hey all-
	Patch to reduce the alignment constraints on ia64 elf core headers.
>From what I can see there is no need to align the elf core header structure to
the EFI_PAGE_SIZE (given that the EFI will never read this data, only the kernel
will when booting a kdump kernel).  And since this is going into our reserved
memory, it saves us 3K (4K vs 1K alignment).  Tested successfully by myself on
several ia64 boxes.

Thanks & Regards
Neil

Signed-off-by: Neil Horman <nhorman at tuxdriver.com>


 crashdump-ia64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/kexec/arch/ia64/crashdump-ia64.c b/kexec/arch/ia64/crashdump-ia64.c
index e365b3e..2aa2b12 100644
--- a/kexec/arch/ia64/crashdump-ia64.c
+++ b/kexec/arch/ia64/crashdump-ia64.c
@@ -231,7 +231,7 @@ int load_crashdump_segments(struct kexec_info *info, struct mem_ehdr *ehdr,
 						       crash_memory_range,
 						       nr_ranges,
 						       &tmp, &sz,
-						       EFI_PAGE_SIZE) < 0)
+						       ELF_CORE_HEADER_ALIGN) < 0)
 				return -1;
 
 			elfcorehdr = add_buffer(info, tmp, sz, sz,
-- 
/****************************************************
 * Neil Horman <nhorman at tuxdriver.com>
 * Software Engineer, Red Hat
 ****************************************************/



More information about the kexec mailing list