[PATCH] Fix wrong remove_parameter() calls

Simon Horman horms at verge.net.au
Thu Jun 12 22:16:30 EDT 2008


On Thu, Jun 12, 2008 at 06:10:25PM +0200, Bernhard Walle wrote:
> When --reuse-cmdline is specified, kexec automatically removes some command
> line parameter that are *known* to break the kexec'd target. That patch
> corrects that behaviour:
> 
>  1. BOOT_IMAGE should be removed always when --reuse-cmdline is specified since
>     it's likely that the kernel is not the same as the running kernel. As only
>     lilo-like bootloaders (i.e. not GRUB) adds that parameter, there's no need
>     to add a BOOT_IMAGE here.
> 
>  2. crashkernel should be only removed when 'kexec -p' is called. For the
>     normal kexec, the crashkernel parameter can be passed as in the
>     running kernel.
> 
> The mistake has been introduced by commit 3c5bb06948881b3e31c783c19edef74275794280
> by myself.

Thans Bernhard, applied.

-- 
Horms




More information about the kexec mailing list