[PATCH 2/2] firmware/memmap: Move kobject initialisation before kobject_add()

Bernhard Walle bwalle at suse.de
Wed Jul 30 16:47:07 EDT 2008

* Andrew Morton <akpm at linux-foundation.org> [2008-07-30 13:40]:
> If you think that "firmware/memmap: Move kobject initialisation before
> kobject_add()" 

Yes, that's what I meant.

> should still be applied then I'd disagree. Adding a
> GFP_KERNEL allocation into kobject_init() was a fairly significant
> backward step.  It's _good_ that kobject_init() can be called this
> early.  Let us strive to retain that robustness.

Ok, since you have more experience with kobject, I'm fine with not
applying that one.

[I saw you merged the first (coding style) patch.]

Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development

More information about the kexec mailing list