[Patch] kexec: remove redundant if-else
Eric W. Biederman
ebiederm at xmission.com
Fri Jul 18 16:07:58 EDT 2008
WANG Cong <xiyou.wangcong at gmail.com> writes:
> These if-else's can be removed.
Why? That appears to be pointless code style thrashing.
Converting code with a single return into code with multiple returns.
Which arguably makes it harder to prove properties about.
Further if you want to use the style you suggest a label name like err
is better than the name out.
But in this case where we have multiple results I don't like the proposed
change in style at all. Especially with no rational.
Eric
More information about the kexec
mailing list