[PATCH -v3 1/7] kexec jump: clean up #ifdef and comments
Huang Ying
ying.huang at intel.com
Wed Aug 13 00:44:49 EDT 2008
On Tue, 2008-08-12 at 20:49 -0700, Andrew Morton wrote:
> On Tue, 12 Aug 2008 11:14:21 +0800 Huang Ying <ying.huang at intel.com> wrote:
>
> > xchg(&kexec_lock, 0);
>
> kernel/kexec.c: In function 'kernel_kexec':
> kernel/kexec.c:1501: warning: value computed is not used
>
> Is there any reason why we cannot use the more conventional
> test_and_set_bit() etc, rather than this peculiarity?
>
> Or perhaps spin_trylock?
Hi, Andrew,
I think it is of no problem to replace xchg() with test_and_set_bit() or
spin_trylock().
Hi, Eric,
Do you have some reason to use xchg() instead of others?
Best Regards,
Huang Ying
More information about the kexec
mailing list