[PATCH] add page flags values to vmcoreinfo

Vivek Goyal vgoyal at redhat.com
Wed Apr 2 13:34:07 EDT 2008


On Fri, Mar 28, 2008 at 06:46:29PM +0900, Ken'ichi Ohmichi wrote:
> 
> Hi,
> 
> This patch adds some values of page flags to the vmcoreinfo data.
> 
> The vmcoreinfo data has the minimum debugging information only
> for dump filtering. makedumpfile (dump filtering command) gets
> it to distinguish unnecessary pages, and makedumpfile creates
> a small dumpfile.
> 
> An old makedumpfile (v1.2.4 or before) had assumed some values
> of page flags internally, and this implementation could not follow
> the change of these values. For example, Christoph Lameter is
> changing these values by the follwing patch:
> http://lkml.org/lkml/2008/2/29/463
> 
> So a new makedumpfile (v1.2.5) came to need these values and I
> created this patch to let the kernel output them. This patch is
> for linux-2.6.25-rc7.
> 
> Signed-off-by: Ken'ichi Ohmichi <oomichi at mxs.nes.nec.co.jp>
> ---
> diff -rpuN linux-2.6.25-rc6.org/kernel/kexec.c linux-2.6.25-rc6/kernel/kexec.c
> --- linux-2.6.25-rc6.org/kernel/kexec.c	2008-03-19 12:12:54.000000000 +0900
> +++ linux-2.6.25-rc6/kernel/kexec.c	2008-03-19 12:14:49.000000000 +0900
> @@ -1406,6 +1406,9 @@ static int __init crash_save_vmcoreinfo_
>  	VMCOREINFO_LENGTH(zone.free_area, MAX_ORDER);
>  	VMCOREINFO_LENGTH(free_area.free_list, MIGRATE_TYPES);
>  	VMCOREINFO_NUMBER(NR_FREE_PAGES);
> +	VMCOREINFO_NUMBER(PG_lru);
> +	VMCOREINFO_NUMBER(PG_private);
> +	VMCOREINFO_NUMBER(PG_swapcache);
>  

Looks good to me. 

Acked-by: Vivek Goyal <vgoyal at redhat.com>

Thanks
Vivek



More information about the kexec mailing list