[PATCH 5/5] Add the array length of "free_list" for filtering free pages
horms at verge.net.au
Fri Nov 16 14:16:30 EST 2007
On Fri, Nov 16, 2007 at 11:33:26AM +0900, Ken'ichi Ohmichi wrote:
> This patch adds the array length of "free_area.free_list" to the vmcoreinfo
> data so that makedumpfile (dump filtering command) can exclude all free pages
> in linux-2.6.24.
> makedumpfile creates a small dumpfile by excluding unnecessary pages for the
> analysis. To distinguish unnecessary pages, makedumpfile gets the vmcoreinfo
> data which has the minimum debugging information only for dump filtering.
> In 2.6.24-rc1 or later, the free_area.free_list is an array which has one list
> for each migrate types instead of a single list. makedumpfile needs the array
> length of "free_area.free_list" and the vmcoreinfo data should contain it.
> Signed-off-by: Huang Ying <ying.huang at intel.com>
> Tested-by: Ken'ichi Ohmichi <oomichi at mxs.nes.nec.co.jp>
This seems fine to me. Though from a point of maintainability
would it be better if VMCOREINFO_LENGTH derived the length
from the element of the type in question. Just a thought,
I haven't hacked it up to see how practical it might be.
Acked-by: Simon Horman <horms at verge.net.au>
More information about the kexec