[patch 3/5] kexec add strict-prototypes
geoffrey.levand at am.sony.com
Tue May 8 10:56:54 EDT 2007
Simon Horman wrote:
> On Mon, May 07, 2007 at 05:02:56PM -0700, Geoff Levand wrote:
>> Add -Wstrict-prototypes to EXTRA_CFLAGS and fix the powerpc compiler warnings.
>> Signed-off-by: Geoff Levand <geoffrey.levand at am.sony.com>
> Hi Geoff,
> I'm all for fixing up this kind of thing, but I'm not sure that
> hardcoding it into -Wstrict-prototypes is the right way to go.
> People who want -Wstrict-prototypes can just add it to CFLAGS
> in the environment and fix problems from there. Then again, it is
> kind of nice to get rid of all this crap :-)
> Could you split the configure.ac patch and the fixes into two separate
> patches so that they can be considered separtely?
Sure. New patches will follow.
> The change to sort_base_ranges() seems like a lot of diff for very
> little change. Is it whitespace fixes. If so could you put that in a
> separate patch?
It is just a move. sort_base_ranges() was defined after
it was used.
More information about the kexec