[patch 1/5] kexec debug output improvments

Simon Horman horms at verge.net.au
Tue May 8 03:24:48 EDT 2007


On Tue, May 08, 2007 at 11:50:19AM +0530, Vivek Goyal wrote:
> On Mon, May 07, 2007 at 05:02:47PM -0700, Geoff Levand wrote:
> > kexec debug output improvments.
> >  - Add better type checking for the debug output macro dfprintf().
> >  - Add a convenence macro dprintf().
> > 
> > Signed-off-by: Geoff Levand <geoffrey.levand at am.sony.com>
> > ---
> >  kexec/kexec.h |    6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > --- kexec-tools-hacked.orig/kexec/kexec.h
> > +++ kexec-tools-hacked/kexec/kexec.h
> > @@ -217,10 +217,12 @@ int parse_iomem_single(char *str, uint64
> > 
> >  #define MAX_LINE	160
> > 
> > +#define dprintf(args...) dfprintf(stdout, args)
> >  #ifdef DEBUG
> > -#define dfprintf(args...)	do {fprintf(args);} while(0)
> > +#define dfprintf(_f, _args...) do {fprintf(_f, _args);} while(0)
> 
> Should't dprintf() also be inside #ifdef DEBUG?

Good point, yes I think so too.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/




More information about the kexec mailing list