[KJ PATCH] Replacing memcpy(dest, src, PAGE_SIZE) with copy_page(dest, src) in arch/i386/kernel/machine_kexec.c

Eric W. Biederman ebiederm at xmission.com
Tue Jun 12 01:32:03 EDT 2007

Shani Moideen <shani.moideen at wipro.com> writes:

> Hi,
> Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in
> arch/i386/kernel/machine_kexec.c.

Please no.

People get creative in copy_page (especially mmx_copy_page),
and this code path need something simple and stupid, that
will work every time, especially when things are messed up

Ideally we would actually do all of the setup before this point.
but that is another issue entirely.


More information about the kexec mailing list