[PATCH] Determine ELF32/ELF64 automatically on i386

[Horms]

On Tue, Jul 10, 2007 at 10:23:16AM +0200, Bernhard Walle wrote:
> * Vivek Goyal <vgoyal at in.ibm.com> [2007-07-10 07:52]:
> > On Tue, Jul 03, 2007 at 06:12:07PM +0200, Bernhard Walle wrote:
> > > On i386, kexec generates ELF64 core headers by default if the user doesn't
> > > override this via a command line option. Because GDB cannot analyse
> > > ELF64 core dumps on 32 bit platforms, it's a bad idea to use ELF64 if it's not
> > > needed.
> > > 
> > > This patch selects ELF32 if the biggest memory address fits in 32 bit address
> > > space, which should be the case on non PAE systems. If the user specifies
> > > a command line option, that option overrides the detection.
> > > 
> > 
> > Makes sense to me. No need to generate 64bit ELF headers on systems
> > having less than 4G of memory. gdb runs into issues with 64bit ELF headers
> > on 32bit machines.
> 
> Exaclty that was my point.
> 
> > I think we can avoid mixed case in "CoreType" and use something like
> > "coretype".
> 
> Of course:
> 
> ----
> 
> [PATCH] Determine ELF32/ELF64 automatically on i386
> 
> On i386, kexec generates ELF64 core headers by default if the user doesn't
> override this via a command line option. Because GDB cannot analyse
> ELF64 core dumps on 32 bit platforms, it's a bad idea to use ELF64 if it's not
> needed.
> 
> This patch selects ELF32 if the biggest memory address fits in 32 bit address
> space, which should be the case on non PAE systems. If the user specifies
> a command line option, that option overrides the detection.

Sorry for being slow, I missed the patch earlier as it wasn't CCed to me.
I have applied it now.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/