[RFC][PATCH 2/2 -mm] kexec based hibernation: kexec restore

Huang, Ying ying.huang at intel.com
Mon Aug 27 21:14:37 EDT 2007

On Mon, 2007-08-27 at 23:31 +0200, Pavel Machek wrote:
> Hi!
> > This patch adds writing support for /dev/oldmem. This is used to
> > restore the memory contents of hibernated system.
> > 
> > Signed-off-by: Huang Ying <ying.huang at intel.com>
> > +ssize_t write_oldmem_page(unsigned long pfn, const char *buf,
> > +			  size_t csize, unsigned long offset, int userbuf)
> Hmm, int userbuf is only ever set to one... Does it make sense to have
> write_oldmem_page in the separate file? The onl user is mem.c, perhaps
> it should go there?

write_oldmem_page is kept to be consistent with copy_oldmem_page as much
as possible. The userbuf is used by copy_oldmem_page too, and
write_oldmem_page is in the same file as copy_oldmem_page. I think the
consistence between them is reasonable.

And the copy_oldmem_page/write_oldmem_page is considered to be
architecture dependent. Now, there are different implementations for
copy_oldmem_page on different architectures. So I think the
copy_oldmem_page/write_oldmem_page should be kept in separate file
instead of go mem.c.

Best Regards,
Huang Ying

More information about the kexec mailing list