[PATCH 2/10] safe_apic_wait_icr_idle - x86_64

[Andi Kleen]

On Wednesday 25 April 2007 14:55:12 Fernando Luis Vázquez Cao wrote:
> On Wed, 2007-04-25 at 14:26 +0200, Andi Kleen wrote:
> > >  static __inline__ void apic_wait_icr_idle(void)
> > >  {
> > > -	while (apic_read( APIC_ICR ) & APIC_ICR_BUSY)
> > > +	while (apic_read(APIC_ICR) & APIC_ICR_BUSY)
> > >  		cpu_relax();
> > >  }
> > >  
> > > +static __inline__ unsigned int safe_apic_wait_icr_idle(void)
> > 
> > This should be probably not inline -- too large
> Hello Andi,
> 
> Thank you for reviewing the patches. Do you want me to resend the whole
> patch or should I cook a new one that un-inlines the function instead?

I already did that.

Also will apply Keith's suggestion.

-Andi