[PATCH] hostapd: Pass BSS tls_flags to tls_global_set_params

[Karsten Sperling]

The tls.h API accepts TLS_CONN_* flags both in tls_init
(tls_config.tls_flags) and tls_global_set_params
(tls_connection_params.flags), and also per connection in
tls_connection_set_params (tls_connection_params.flags) and
tls_connection_set_verify (flags).

authsrv_init passes the BSS tls_flags to tls_init, but was passing flags
== 0 in the subsequent tls_global_set_params call. Depending on how a
particular backend implements flag handling in these 4 functions, this
can have the effect of clobbering configuration that the tls_init call
set up.

For example, with the wolfSSL backend if the [SUITEB] tls_flag is set on
the BSS but no explicit list of ciphers is configured, tls_init will
configure the relevant Suite-B ciphers, but tls_global_set_params with
flags = 0 will reset the cipher list back to default. The BSS tls_flags
also make their way into tls_connection_set_verify, but wolfSSL doesn't
happen to re-apply the ciphers based on the SUITEB flag at that point.

The tls.h documentation does not document whether subsequent calls are
intended to fully replace or only augment flags and other state, but
given the variations between backends, passing (as much as possible) the
same flags to all functions seems prudent.

Note that on the OpenSSL backend this change has no impact, since
tls_global_set_params ignores all flags other than
DISABLE_SESSION_TICKET, which is later re-configured per connection in
tls_connection_set_verify.

Signed-off-by: Karsten Sperling <ksperling at apple.com>
---
 src/ap/authsrv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/ap/authsrv.c b/src/ap/authsrv.c
index 3e8031810..26f54bc3e 100644
--- a/src/ap/authsrv.c
+++ b/src/ap/authsrv.c
@@ -437,6 +437,7 @@ int authsrv_init(struct hostapd_data *hapd)
 		params.ocsp_stapling_response_multi =
 			hapd->conf->ocsp_stapling_response_multi;
 		params.check_cert_subject = hapd->conf->check_cert_subject;
+		params.flags = hapd->conf->tls_flags;
 
 		if (tls_global_set_params(hapd->ssl_ctx, &params)) {
 			wpa_printf(MSG_ERROR, "Failed to set TLS parameters");
-- 
2.50.1 (Apple Git-155)