[PATCH] GAS server: Use shorter wait after responses that expect a comeback
Gustavo Bertoli
gubertoli at gmail.com
Wed Nov 18 02:34:02 PST 2026
The Initial Response with a comeback delay and a response fragment with
more fragments to follow are sent with a 2 s wait to receive the next
Comeback Request. Such a frame is often sent while the wait of an
earlier Action frame on the same channel is still running. A driver
that implements remain-on-channel itself, such as iwlwifi, holds a
frame whose wait does not fit in the remaining time until that earlier
wait ends, and by then the requester has stopped listening.
Use a 500 ms wait, which fits. The requester comes back right after a
fragment, and after a comeback delay DPP starts a listen when the wait
expires.
Tested on air with both kinds of remain-on-channel. With drivers that
use the mac80211 implementation (ath9k_htc, rtw88) the results are
unchanged, and with one that implements it itself (iwlwifi) the DPP
Enterprise configuration exchange, which failed every time, now
completes.
Signed-off-by: Gustavo Bertoli <gubertoli at gmail.com>
---
src/common/gas_server.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/common/gas_server.c b/src/common/gas_server.c
index 51f6a572e..be4ce2108 100644
--- a/src/common/gas_server.c
+++ b/src/common/gas_server.c
@@ -167,7 +167,7 @@ gas_server_send_resp(struct gas_server *gas,
response->resp = query_resp;
response->initial_resp_sent = true;
gas->tx(gas->ctx, response->freq, response->dst, resp,
- comeback_delay ? 2000 : 0);
+ comeback_delay ? 500 : 0);
wpabuf_free(resp);
eloop_register_timeout(GAS_QUERY_TIMEOUT, 0,
gas_server_response_timeout, response, NULL);
@@ -347,7 +347,7 @@ gas_server_handle_rx_comeback_req(struct gas_server_response *response)
response->offset += resp_frag_len;
if (remaining > resp_frag_len)
- wait_time = 2000;
+ wait_time = 500;
send_resp:
gas->tx(gas->ctx, response->freq, response->dst, resp, wait_time);
--
2.43.0
More information about the Hostap
mailing list