[PATCH v3 18/46] nl80211: Add Proximity Detection (PD) wdev support

[Jouni Malinen]

On Wed, May 13, 2026 at 03:29:42PM +0530, Kavita Kavita wrote:
> diff --git a/src/drivers/driver.h b/src/drivers/driver.h
> +#ifdef CONFIG_PR
> +	/**
> +	 * pd_start - Create and activate a PD (Proximity Detection) wdev
> +	 * @priv: Private driver interface data
> +	 * @addr: Requested MAC address for the PD wdev
> +	 * @pd_addr: Buffer (ETH_ALEN) to receive the actual assigned MAC
> +	 * Returns: 0 on success, -1 on failure
> +	 *
> +	 * Creates a PD virtual interface in the driver and activates it via
> +	 * NL80211_CMD_START_PD.  The PD wdev is associated with the parent
> +	 * BSS; all PD operations (key install, TX, peer measurement) are
> +	 * routed through it by matching the PD MAC address.
> +	 */
> +	int (*pd_start)(void *priv, const u8 *addr, u8 *pd_addr);
> +
> +	/**
> +	 * pd_stop - Stop and destroy the PD wdev
> +	 * @priv: Private driver interface data
> +	 *
> +	 * Sends NL80211_CMD_STOP_PD, deletes the PD wdev via
> +	 * NL80211_CMD_DEL_INTERFACE, and frees all associated driver
> +	 * resources.  Safe to call when no PD wdev is active (no-op).
> +	 */
> +	void (*pd_stop)(void *priv);

These are specific to nl80211 while driver.h is supposed to be generic
interface. Please reword all this to not use nl80211-specific terms
(wdev or anything with nl80211 in the name).

-- 
Jouni Malinen                                            PGP id EFC895FA