[PATCH] hostapd: send own Neighbor Report only if specific Measurement Request

[David Bauer]

Hi Pablo,

On 5/21/25 18:06, Pablo MARTIN-GOMEZ wrote:
> Every Neighbor Report that matches the requested SSID is sent in the
> Neighbor Report Response, including our own report. According to standard
> IEEE 802.11-2020 (11.10.10.3), the self report should not be included in
> the response unless the request includes a LCI Measurement Request or a
> Location Civic Measurement Request.

I read the standard as a "can not have" not a "should not"

> [...] then the AP shall include a Neighbor Report element for the AP’s
> own BSSID in the Neighbor Report Response frame [...]

I think the change is correct and should be applied, I'm just a bit
confused with the description.

If i missed the part where it stated "should not contain", please
correct me.

Best
David

> 
> Signed-off-by: Pablo Martin-Gomez <pmartin-gomez at freebox.fr>
> ---
>   src/ap/rrm.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/src/ap/rrm.c b/src/ap/rrm.c
> index fbcddf3f9..0fdda9958 100644
> --- a/src/ap/rrm.c
> +++ b/src/ap/rrm.c
> @@ -227,6 +227,10 @@ static void hostapd_send_nei_report_resp(struct hostapd_data *hapd,
>               os_memcmp(ssid->ssid, nr->ssid.ssid, ssid->ssid_len) != 0)
>               continue;
> 
> +        /* Only send own report if Measurement Type is LCI or Location Civic. */
> +        if (!civic && !lci && os_memcmp(hapd->own_addr, nr->bssid, ETH_ALEN) == 0)
> +            continue;
> +
>           send_lci = (lci != 0) && hostapd_check_lci_age(nr, lci_max_age);
>           len = hostapd_neighbor_report_len(buf, nr, send_lci, civic);
>