[PATCH] hostapd: send own Neighbor Report only if specific Measurement Request

[Pablo MARTIN-GOMEZ]

Hi David,
On 29/05/2025 13:00, David Bauer wrote:
> Hi Pablo,
>
> On 5/21/25 18:06, Pablo MARTIN-GOMEZ wrote:
>> Every Neighbor Report that matches the requested SSID is sent in the
>> Neighbor Report Response, including our own report. According to 
>> standard
>> IEEE 802.11-2020 (11.10.10.3), the self report should not be included in
>> the response unless the request includes a LCI Measurement Request or a
>> Location Civic Measurement Request.
>
> I read the standard as a "can not have" not a "should not"
>
>> [...] then the AP shall include a Neighbor Report element for the AP’s
>> own BSSID in the Neighbor Report Response frame [...]
>
> I think the change is correct and should be applied, I'm just a bit
> confused with the description.
>
> If i missed the part where it stated "should not contain", please
> correct me.

To be honest, I find the standard to be unclear on that point. It's 
clear when the self Neighbor Report has to be included but outside of 
those conditions, the standard has no "shall not include" so I sort of 
deduced from the "spirit" of the standard that the self Neighbor Report 
is not expected to be included otherwise .

One could even claim that:

 > NOTE—The Neighbor Report Response frame includes a list of Neighbor 
Report elements one for each neighbor. The
 > criteria for the selection of an AP as a neighbor AP is beyond the 
scope of this specification.

can be interpreted as an implementer is free to consider an AP as its 
own neighbor AP and therefor send a self Neighbor Report by default. So 
I'm not even sure about the "spirit" of the standard.

>
> Best
> David

Best regards,

Pablo