commit "wolfssl: Implement RSA-OAEP-SHA256 for EAP-AKA privacy protection" seems broken

[Jouni Malinen]

On Mon, Feb 03, 2025 at 08:31:41PM +0200, Rany Hany wrote:
> While trying to compile hostapd[1] with WolfSSL 5.7.6 as TLS backend, I am
> getting the following error:
> 
> 3617 | struct DecodedCert cert; | ^~~~
> ../src/crypto/crypto_wolfssl.c:3630:46: error: 'NO_VERIFY' undeclared (first
> use in this function) 3630 | err = wc_ParseCert(&cert, CERT_TYPE, NO_VERIFY,
> NULL); | ^~~~~~~~~ ../src/crypto/crypto_wolfssl.c:3630:46: note: each
> undeclared identifier is reported only once for each function it appears in
> ../src/crypto/crypto_wolfssl.c: In function 'crypto_rsa_key_read':
> ../src/crypto/crypto_wolfssl.c:3707:42: error: 'RSAk' undeclared (first use
> in this function) 3707 | if (private_key && key_format != RSAk) { | ^~~~

It looks like the asn.h that is needed for this gets pulled in
automatically through some other header whenever DPP functionality is
included.

> I have managed to resolve the issue with the following patch:

> diff --git a/src/crypto/crypto_wolfssl.c b/src/crypto/crypto_wolfssl.c
> -#include <wolfssl/wolfcrypt/asn_public.h>
> +#include <wolfssl/wolfcrypt/asn.h>

I would not remove asn_public.h, but I'll add explicit inclusion of
asn.h tocover the no-DPP build cases.

-- 
Jouni Malinen                                            PGP id EFC895FA