[PATCH v5 3/6] hostapd_cli: MLO: pass 'LINKID' in the command

Aditya Kumar Singh quic_adisi at quicinc.com
Mon Sep 2 00:19:12 PDT 2024


On 9/1/24 14:25, Jouni Malinen wrote:
> On Tue, Aug 13, 2024 at 02:08:49PM +0530, Aditya Kumar Singh wrote:
>> MLD level socket can take 'LINKID <link id>'. Add changes to pass this via
>> hostapd_cli. User needs to give "link_id=<link_id>" in post fix fashion in
>> the command in order to pass this link_id from cli.
> 
> This use of a postfix in the hostapd_cli command has the same issue as
> postfix LINKID in the actually control interface command has, i.e., it
> can be mixed up with other parts of the command.

That's true. But if we bring this one in prefix then while parsing the 
command and checking if a command already exist or not might need some 
additional changes. Like user can give or might not give link_id. So 
conditionally we have to check and parse. Then get to that actual 
command and see if command exist or not.

> 
>> For example -
>> $ hostapd_cli -i wlan0 status link_id=0 | grep freq=
>> freq=2437
> 
> This is this even needed in hostapd_cli? Isn't it much cleaner to use
> the -l command line parameter for per-link operations?

Yeah but since now we have MLD level socket, user would want to get info 
from any one of underlying link from the MLD level socket itself right?
For example assume MLD level socket is opened in an interactive way.
Now first user might wanna check how many STAs on link 0. Next want to 
check status of link 1 but without disconnecting from the interactive shell.

-- 
Aditya




More information about the Hostap mailing list