[PATCH 11/16] hostapd: MLO: add support to remove the link before removing interface

[Aditya Kumar Singh]

On 3/18/24 18:25, Benjamin Berg wrote:
...
>> +static int driver_nl80211_if_link_remove(void *priv, enum
>> wpa_driver_if_type type,
>> +					 const char *ifname, s8
>> link_id)
>> +{
>> +	struct i802_bss *bss = priv;
>> +
>> +	if (link_id < 0 || link_id >= MAX_NUM_MLD_LINKS)
>> +		return -1;
>> +
>> +	if (type != WPA_IF_AP_BSS)
>> +		return -1;
>> +
>> +	if (!(bss->valid_links & BIT(link_id)))
>> +		return -1;
>> +
> 
> Maybe use nl80211_link_valid here?
> 

Yeah can be used. Good point.

...
>> diff --git a/src/drivers/driver_nl80211.h b/src/drivers/driver_nl80211.h
>> index 03d3c333b3d1..3e5a53452f00 100644
>> --- a/src/drivers/driver_nl80211.h
>> +++ b/src/drivers/driver_nl80211.h
>> @@ -352,6 +352,7 @@ const char * nl80211_iftype_str(enum nl80211_iftype mode);
>>   
>>   void nl80211_restore_ap_mode(struct i802_bss *bss);
>>   struct i802_link * nl80211_get_link(struct i802_bss *bss, s8 link_id);
>> +int nl80211_is_valid_link(struct i802_bss *bss, s8 link_id);
>>   
>>   static inline bool nl80211_link_valid(u16 links, s8 link_id)
>>   {
> 
> This looks like a left-over after a merge conflict or so. I kind of

Oh yeah! Thanks for pointing it out. It can be removed. I'm surprised 
that for some reason the compilation did not flag this unused function 
prototype.

> like the nl80211_is_valid_link name more though.

May be later we can simply rename this function ;-p


Hi Jouni,

Will you fix these (minor changes) while applying or shall I re-spin a 
new version?