[PATCH 03/10] PMKSA: Guard against NULL KCK
benjamin at sipsolutions.net
benjamin at sipsolutions.net
Fri Jun 14 01:13:44 PDT 2024
From: Benjamin Berg <benjamin.berg at intel.com>
If the kck_len is 0 then the pointer may be NULL. If that happens UBSAN
complains about the NULL pointer as memcpy has the arguments declared to
never be NULL.
Signed-off-by: Benjamin Berg <benjamin.berg at intel.com>
---
src/rsn_supp/pmksa_cache.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/rsn_supp/pmksa_cache.c b/src/rsn_supp/pmksa_cache.c
index f90dcd9b0a..5bfcbd27e8 100644
--- a/src/rsn_supp/pmksa_cache.c
+++ b/src/rsn_supp/pmksa_cache.c
@@ -253,7 +253,8 @@ pmksa_cache_add(struct rsn_pmksa_cache *pmksa, const u8 *pmk, size_t pmk_len,
return NULL;
os_memcpy(entry->pmk, pmk, pmk_len);
entry->pmk_len = pmk_len;
- os_memcpy(entry->kck, kck, kck_len);
+ if (kck_len > 0)
+ os_memcpy(entry->kck, kck, kck_len);
entry->kck_len = kck_len;
if (pmkid)
os_memcpy(entry->pmkid, pmkid, PMKID_LEN);
--
2.45.1
More information about the Hostap
mailing list