[PATCH] Fix the wrapping of dBus container for SignalPoll

Kaidong Wang kaidong at chromium.org
Mon Jan 22 14:38:27 PST 2024

Thanks for the information!
https://w1.fi/wpa_supplicant/devel/dbus.html shows SignalPoll returns
a{sv} properties, while the code wraps the dict as a variant, which
causes implicit unwrapping in our code.
Similar wrapping is also seen in other places such as
wpas_dbus_simple_array_property_getter(), wpas_dbus_getter_bss_wps(),
wpas_dbus_getter_network_properties(). If we want to maintain this
behavior for compatibility or whatever reason, we might update the
documentation to clarify that it is WAI, otherwise I can submit
another patch to remove all these variant wrappings.

Best regards

On Sat, Jan 20, 2024 at 10:13 AM Jouni Malinen <j at w1.fi> wrote:
> On Thu, Jan 18, 2024 at 11:16:06AM -0800, Kaidong Wang wrote:
> > This patch removes the wrapping of variants for SignalPoll, but I saw
> > this wrapping also used for all dict containers. Is this wrapping
> > expected?
> I have to admit that I do not know why that design was used, but it was
> present from the very first commit that added the new DBus API in 2009..
> --
> Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list