[PATCH] Change logging level for CTRL-EVENT-SIGNAL-CHANGE to MSG_DEBUG

[Jouni Malinen]

On Thu, Nov 28, 2024 at 12:18:37AM +0900, Kan-Ru Chen wrote:
> The default logging level for the CTRL-EVENT-SIGNAL-CHANGE message
> may be repeated many times and fill the log file or journal.
> 
> For example https://bugzilla.redhat.com/show_bug.cgi?id=2309148 and
> the first few results from searching CTRL-EVENT-SIGNAL-CHANGE on the
> web contain various complaints and workarounds.
> 
> Changing the logging level to MSG_DEBUG would allow the message to
> be still useful for debugging.

This event is not really for debugging purposes, but for providing it to
any upper layer component that is listening to event message in the
wpa_supplicant control interface.

> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
> @@ -6755,7 +6755,7 @@ void wpa_supplicant_event(void *ctx, enum wpa_event_type event,
>  	case EVENT_SIGNAL_CHANGE:
> -		wpa_msg(wpa_s, MSG_INFO, WPA_EVENT_SIGNAL_CHANGE
> +		wpa_msg(wpa_s, MSG_DEBUG, WPA_EVENT_SIGNAL_CHANGE
>  			"above=%d signal=%d noise=%d txrate=%lu",

This would break existing uses for the wpa_supplicant control interface.
I'm not completely sure how those system log messages get collected, but
a more appropriate change might be to replace this wpa_msg() call with a
call to wpa_msg_ctrl() with the exact same set of parameters. That would
remove the print from stdout and hopefully from the undesired system log
mechanisms.

-- 
Jouni Malinen                                            PGP id EFC895FA