[PATCH v3 2/6] ctrl_iface: MLO: introduce MLD level socket

[Aditya Kumar Singh]

On 8/13/24 00:34, Jouni Malinen wrote:
> On Tue, Aug 06, 2024 at 11:47:27AM +0530, Aditya Kumar Singh wrote:
>> On 8/5/24 22:55, Jouni Malinen wrote:
>>> Is there a plan to use those hostapd_mld_ctrl_iface_{attach,detach}()
>>> functions for something else than for wrapping a call to
>>> ctrl_iface_{attach,detach}()? I would simply call the existing functions
>>> directly instead of going through that minimal wrapper function.
>>
>> Now that I see, this was done in order to have similar naming link for
>> non-AP MLD. Please see hostapd_ctrl_iface_attach(). So similarly, for MLD as
>> well the wrapper is introduced. Do you still want to remove the wrapper?
> 
> hostapd_ctrl_iface_attach() used to contain the implementation and that
> ended up being a minimal wrapper when the function was shared for
> multiple purposes in commit 89b781bc89ef ("hostapd: Use common functions
> for ctrl_iface"). It was never cleaned up, but I guess better late than
> never.. So yes, I think the one-liner wrapper should be removed if there
> is no plan on extending it (and independently of that, the existing
> one-liner wrappers from that commit could be removed).
>   

:) Sure, got it, will do as suggested.

-- 
Aditya