[EXT] Re: [PATCH] hostapd: Rename event handling functions in hostapd for

[Hui Bai]

Hi Jouni Malinen,

Currently on Zephyr, we are using Monolithic build, which means both wpa_supplicant and hostapd files will be built into one single binary. 
I didn't quite get your idea of using function pointers to the driver interface. But based on my understanding, even I take your suggestions, the redefinition build error will still occurred with Monolithic build.

Regards,
Hui Bai

-----Original Message-----
From: Jouni Malinen <j at w1.fi> 
Sent: Saturday, August 10, 2024 3:49 PM
To: Hui Bai <hui.bai at nxp.com>
Cc: hostap at lists.infradead.org
Subject: [EXT] Re: [PATCH] hostapd: Rename event handling functions in hostapd for

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button


On Thu, Jun 13, 2024 at 06:32:01AM +0000, Hui Bai wrote:
> On Zephyr, both wpa_supplicant and hostapd are supported. One compilation error was found due to function name conflict.
> Both wpa_supplicant and hostapd has its own global event and event handlers with same name:
> wpa_supplicant_event
> wpa_supplicant_event_global
>
> To fix the compilation error, rename above functions in hostapd for Zephyr as below:
> hostapd_event
> hostapd_event_global

This does not look like something that would really work at all in hostap.git, i.e., this is based on something that has other changes and as such, I'm not sure why this particular change should be in hostap.git.

Those functions have the same name for a reason, i.e., those are the functions that are called from the driver interface code for either hostapd or wpa_supplicant. If there is need to make this work with both hostapd and wpa_supplicant somehow linked into a single binary, the driver wrappers would need changes. For that, the cleaner way of updating the design would be by registering wpa_supplicant_event and wpa_supplicant_event_global as function pointers to the driver interface and using those function pointers instead of direct calls. That is something that I could consider applying to hostap.git.

--
Jouni Malinen                                            PGP id EFC895FA