[PATCH v2 3/5] bss: don't add hidden OWE transition-networks to scan-list

[David Bauer]

Hi Jouni,

thanks for your review.

On 8/1/24 17:13, Jouni Malinen wrote:
> On Sun, Apr 28, 2024 at 03:13:42PM +0200, David Bauer wrote:
>> When adding these networks hidden, they get re-added for the same BSSID
>> when scanning for the transition-SSID. Skip adding the OWE-SSIDs in case
>> the SSID was not explicitly scanned for.
> 
> This breaks multiple hwsim test cases for OWE since the expected BSS
> entry is not available. While I think I understand what this is trying
> to do, it is not really acceptable to break test cases, so I cannot
> apply this as-is. At minimum, those test cases would need to be
> modified, but I'm not really sure this is actually correct behavior
> since BSSs with a hidden SSID have been added to the scan results in all
> existing cases for years.

Understood. How about replacing hidden scan entries when we discover the
SSID name upon trying to connect to the transition network?

I hope it is understandable what i mean. Currently the scan-list is flooded
with multiple entries for a single BSSID. As all roaming code just takes
the first one upon iterating, this effectively breaks roaming at the moment.

Best
David

> 
>> +	/* Don't add hidden OWE transition networks with RSN. They are explicitly scanned for. */
>> +	rsn = wpa_scan_get_ie(res, WLAN_EID_RSN);
>> +	owe = wpa_scan_get_vendor_ie(res, OWE_IE_VENDOR_TYPE);
>> +	if (owe && rsn && (ssid[1] == 0 || ssid[2] == 0))
>> +		return;
> 
> And this should likely be within #ifdef CONFIG_OWE even if that were to
> compile successfully without such conditional check.
>