[PATCH 1/6] ctrl_iface: create link based hapd control sockets

[Aditya Kumar Singh]

On 8/1/24 20:09, Jouni Malinen wrote:
> On Tue, Apr 23, 2024 at 11:01:23AM +0530, Aditya Kumar Singh wrote:
>> Create link based control sockets to access the link based commands
>> through hostapd_cli. This will create the link interfaces in the name of
>> wlan<X>_link<X>
>>
>> Example:
>> To fetch link 0 status from wlan0, below command can be used -
>>      $ hostapd_cli -i wlan0 -l 0 status
>>
>> On failure of link/interface selection, below error will be observed
>>      $ hostapd_cli -i wlan0 -l 2 status
>>      Failed to connect to hostapd - wpa_ctrl_open: No such file or directory
> 
> This breaks eht_mld_cohosted_discovery and eht_mlo_color_change test
> cases:
> 
> START eht_mld_cohosted_discovery 1/2
> Traceback (most recent call last):
>    File "/home/jm/Git/hostap/tests/hwsim/./run-tests.py", line 589, in main
>      t(dev, apdev, params)
>    File "/home/jm/Git/hostap/tests/hwsim/test_eht.py", line 2080, in test_eht_mld_cohosted_discovery
>      eht_mld_cohosted_discovery(dev, apdev, params)
>    File "/home/jm/Git/hostap/tests/hwsim/test_eht.py", line 2050, in eht_mld_cohosted_discovery
>      hapds = get_mld_devs(hapd_iface=hapd_iface, count=2,
>    File "/home/jm/Git/hostap/tests/hwsim/test_eht.py", line 1959, in get_mld_devs
>      hapd_mld1_link0 = hostapd.Hostapd(ifname=hapds1[0][0], ctrl=hapds1[0][1],
>    File "/home/jm/Git/hostap/tests/hwsim/hostapd.py", line 155, in __init__
>      self.ctrl = wpaspy.Ctrl(os.path.join(ctrl, ifname))
>    File "/home/jm/Git/hostap/tests/hwsim/../../wpaspy/wpaspy.py", line 40, in __init__
>      self.s.connect(self.dest)
> FileNotFoundError: [Errno 2] No such file or directory
> Exception: [Errno 2] No such file or directory
> FAIL eht_mld_cohosted_discovery 2.002865 2024-08-01 14:37:40.010584
> START eht_mlo_color_change 2/2
> Traceback (most recent call last):
>    File "/home/jm/Git/hostap/tests/hwsim/./run-tests.py", line 591, in main
>      t(dev, apdev)
>    File "/home/jm/Git/hostap/tests/hwsim/test_eht.py", line 2147, in test_eht_mlo_color_change
>      hapd0 = eht_mld_enable_ap(hapd_iface, params)
>    File "/home/jm/Git/hostap/tests/hwsim/test_eht.py", line 242, in eht_mld_enable_ap
>      hapd = hostapd.add_mld_link(iface, params)
>    File "/home/jm/Git/hostap/tests/hwsim/hostapd.py", line 752, in add_mld_link
>      hapd = Hostapd(ifname, hostname=hostname, ctrl=ctrl_iface, port=port)
>    File "/home/jm/Git/hostap/tests/hwsim/hostapd.py", line 155, in __init__
>      self.ctrl = wpaspy.Ctrl(os.path.join(ctrl, ifname))
>    File "/home/jm/Git/hostap/tests/hwsim/../../wpaspy/wpaspy.py", line 40, in __init__
>      self.s.connect(self.dest)
> FileNotFoundError: [Errno 2] No such file or directory
> Exception: [Errno 2] No such file or directory
> FAIL eht_mlo_color_change 0.000361 2024-08-01 14:37:40.010949
> 

Ah! Right! These test cases got added after the patch was created hence 
the test cases isn't modified as per the MLO control sockets use case. 
Let me quickly rebase and send a new version!

-- 
Aditya