[PATCH 05/22] hostapd: MLO: handle auth/assoc on link address

Jouni Malinen j at w1.fi
Tue Apr 16 01:05:52 PDT 2024

On Thu, Mar 28, 2024 at 11:46:35PM +0530, Aditya Kumar Singh wrote:
> Modify authentication and association frames to be always sent with link
> address as A1 and A3 for ease of Tx status handling.

It would be nice to get a bit more complete commit message that explains
why this can be done. Surely there was some reason for the previous more
complex design..

> diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c

> @@ -444,7 +437,7 @@ static int send_auth_reply(struct hostapd_data *hapd, struct sta_info *sta,
> -	os_memcpy(reply->bssid, bssid, ETH_ALEN);
> +	os_memcpy(reply->bssid, sa, ETH_ALEN);

This removes the only use of bssid in send_auth_reply(). Is that really
correct for all cases? It might be, but again, this needs more
justification in the commit message. In addition, this should remove the
bssid argument from this function and potentially in a number of calling
functions as well since all the would now be unused.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list