[PATCH 1/1] hostapd: Add support for OWE offload for STA/AP interface

[Vinayak Yadawad]

Thanks for the review comments. NL80211_CMD_UPDATE_OWE_INFO event is
expected only from drivers where OWE offload is not supported.
For drivers supporting OWE offload, this event handling can be
skipped. I will update the patch accordingly.

Regards,
Vinayak


On Sun, Oct 29, 2023 at 10:08 PM Jouni Malinen <j at w1.fi> wrote:
>
> On Fri, Oct 27, 2023 at 06:54:03PM +0530, Vinayak Yadawad wrote:
> > The current change enables OWE DH IE inclusion and processing
> > of peer DH IE to generate PMK by the driver. The OWE offload
> > is enabled based on NL80211_EXT_FEATURE_OWE_OFFLOAD flag
> > advertised by the driver.
>
> > diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
> > @@ -3738,14 +3739,17 @@ u16 owe_process_rsn_ie(struct hostapd_data *hapd,
> >       status = wpa_res_to_status_code(res);
> >       if (status != WLAN_STATUS_SUCCESS)
> >               goto end;
> > -     status = owe_process_assoc_req(hapd, sta, owe_dh, owe_dh_len);
> > -     if (status != WLAN_STATUS_SUCCESS)
> > -             goto end;
> > -     owe_buf = wpa_auth_write_assoc_resp_owe(sta->wpa_sm, ie, sizeof(ie),
> > -                                             NULL, 0);
> > -     if (!owe_buf) {
> > -             status = WLAN_STATUS_UNSPECIFIED_FAILURE;
> > -             goto end;
> > +
> > +     if (!(iface->drv_flags & WPA_DRIVER_FLAGS2_OWE_OFFLOAD_AP)) {
> > +             status = owe_process_assoc_req(hapd, sta, owe_dh, owe_dh_len);
> > +             if (status != WLAN_STATUS_SUCCESS)
> > +                     goto end;
> > +             owe_buf = wpa_auth_write_assoc_resp_owe(sta->wpa_sm, ie, sizeof(ie),
> > +                                                     NULL, 0);
> > +             if (!owe_buf) {
> > +                     status = WLAN_STATUS_UNSPECIFIED_FAILURE;
> > +                     goto end;
> > +             }
> >       }
> >
> >       if (sta->owe_ecdh) {
>
> What is this trying to do? The offloaded case would look really strange
> here since this sta->owe_ecdh part would trigger use of uninitialized
> owe_buf.. It would also feel strange to call hostapd_drv_update_dh_ie()
> with offload. Is that really what is supposed to happen here?
>
> --
> Jouni Malinen                                            PGP id EFC895FA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4218 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/hostap/attachments/20231031/5f5effba/attachment.p7s>