[PATCH] Add an option to remove advanced features

[Jouni Malinen]

On Wed, Oct 11, 2023 at 08:49:37PM +0530, Chaitanya Tata wrote:
> For a memory constrained system, basic Wi-Fi is enough, so, add a
> configuration option to compiled out advanced Wi-Fi features but seldom
> used as below:
> 
> * RRM
> * Robust AV
> * WMM-AC

It would be fine to make these conditional components in the build,
but..

> diff --git a/wpa_supplicant/defconfig b/wpa_supplicant/defconfig
> +# Radio Measurement (IEEE 802.11k)
> +CONFIG_RRM=y
> +
> +# WMM admission control
> +CONFIG_WMM_AC=y
> +
> +# Robust AV streaming for consumer and enterprise Wi-Fi applications 802.11-202 (4.3.24)
> +CONFIG_ROBUST_AV=y

.. this way of doing that would result in unexpected changes to existing
cases when updated hostap.git version since the in-use .config would not
be modified automatically. At minimum, wpa_supplicant/android.config
would need to be updated in similar manner. Another approach would be to
use items like CONFIG_NO_RRM=y to remove functionality that used to be
included by default. There are examples of both of those cases in the
past, e.g., with CONFIG_WEP=y where the goal is to remove WEP from
builds completely while having to maintain it temporarily for Android
and with CONFIG_NO_TKIP=y where there is no immediate goal to remove it
completely, but to provide an option for doing that now and potentially
changing this to remove the functionality in future. That said, there is
no goal of completely removing RRM/WMM-AC/Robust AV in long term.

Please also note that wpa_supplicant/Android.mk would need changes to
avoid breaking Android builds.
 
-- 
Jouni Malinen                                            PGP id EFC895FA